Comments on: Building Browsergames: Implementing a flexible stats system (PHP)

By: Luke

Luke — Thu, 26 Nov 2009 20:15:02 +0000

Thanks for the tip, Name!

By: Name

Name — Thu, 26 Nov 2009 16:11:15 +0000

Don't use subqueries, where an inner join is more likely (and probably faster).

Change this:


SELECT value
FROM user_stats
WHERE stat_id = (
   SELECT id 
   FROM stats 
   WHERE display_name =  OR short_name = )
AND user_id =

to this:


SELECT user_stats.value
FROM user_stats
INNER JOIN stats
   ON (user_stats.stat_id = stats.id)
WHERE stats.display_name =  AND stats.short_name =  AND user_stats.user_id =

By: Luke

Luke — Thu, 26 Nov 2009 14:15:02 +0000

Thanks for the tip, Name!

By: Name

Name — Thu, 26 Nov 2009 10:11:15 +0000

Don't use subqueries, where an inner join is more likely (and probably faster).

Change this:


SELECT value
FROM user_stats
WHERE stat_id = (
   SELECT id 
   FROM stats 
   WHERE display_name =  OR short_name = )
AND user_id =

to this:


SELECT user_stats.value
FROM user_stats
INNER JOIN stats
   ON (user_stats.stat_id = stats.id)
WHERE stats.display_name =  AND stats.short_name =  AND user_stats.user_id =

By: Luke

Luke — Thu, 08 Oct 2009 16:38:33 +0000

You need to actually put values into the and portions – if you read a little further, the code to do that is later on.

By: Luke

Luke — Wed, 10 Jun 2009 19:06:16 +0000

You're missing the string formatting that puts arguments into your SQL
statement – add that, and you should be good to go.

By: sHyuAn

sHyuAn — Wed, 10 Jun 2009 17:26:02 +0000

"SELECT value FROM user_stats WHERE stat_id = (SELECT id FROM stats WHERE display_name = OR short_name = ) AND user_id = "

i have inserted this into sql query.. however, the error message came out as below:

"MySQL said:

#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' OR short_name = ) AND user_id =
LIMIT 0, 30' at line 1"

what should I do now?

By: Free Content for your Website

Free Content for your Website — Mon, 16 Mar 2009 22:49:51 +0000

Does subqueries work on MySQL 4.x or they were added on MySQL 5.x only?