Comments on: Building Browsergames: Reducing Repetition (PHP)

By: Patrick

Patrick — Fri, 02 Apr 2010 03:10:58 +0000

I did the same on the monster_stats and items as well as stats.php. Then when I try to go fight a monster this error comes up: Fatal error: Cannot redeclare getStat() (previously declared in H:XAMPPxampphtdocsstats.php:7) in H:XAMPPxampphtdocsmonster_stats.php on line 9.
If you could show me what the other two codes are supposed to look like that would be very helpful. Thank you.

By: Luke

Luke — Tue, 08 Jul 2008 23:21:46 +0000

Thanks for the tip, sepp – I’ll have to look into that as well(it looks like this will be the week of re-designing for DRY =P)

By: sepp

sepp — Tue, 08 Jul 2008 19:59:55 +0000

Hey, that’s great you considered my notes. I’m honored =) .

Actually if you try to keep your code dry you could also expand this principle to cover your database design, too. Why not only have one stats table instead of three or more? Simply call one column “type” again (with ENUM) to choose which stats you want to select, add, delete or update. I haven’t read the whole code absolutely attentively, but I ran over it . The tables seem to be pretty exactly the same.

Greetings from FEtMab
Sepp